Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search queries in the "Top search queries" widget are overflowing on the shared dashboard at narrow viewports #8417

Closed
3 tasks done
techanvil opened this issue Mar 21, 2024 · 2 comments
Labels
Module: Search Console Search Console module related issues P1 Medium priority Team S Issues for Squad 1 Type: Bug Something isn't working

Comments

@techanvil
Copy link
Collaborator

techanvil commented Mar 21, 2024

Bug Description

When viewing the "Top search queries" widget on the shared dashboard at narrow viewports, long search queries can currently overflow the clicks and impressions metrics.

Steps to reproduce

  1. Login to Site Kit as an admin and share Search Console.
  2. Login as a second user with shared access to Search Console and scroll down to the "Top search queries" widget.
  3. Ensure the viewport is set to a relatively narrow width.
  4. See that long search queries overflow the clicks and impressions metrics.
  5. Note that this is of course dependent on having some long search queries appear in the list for the connected Analytics property. I discovered this using the oi.ie property. Alternatively, it can be verified using Storybook by making the search results a bit longer for the view-only story.

Screenshots

Search queries overflow in the "Top search queries" widget:
image

They should show ellipses similarly to the "Top performing keywords" Key Metrics widget:
image

Additional Context

  • PHP Version: any
  • OS: any
  • Browser: any with a narrow enough viewport
  • Plugin Version: noticed on 1.122.0
  • Device: any

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When viewing the "Top search queries" widget on the shared dashboard at narrow viewports, long search queries should not overflow the clicks and impressions metrics, and should instead be truncated with ellipses (similarly to the "Top performing keywords" Key Metrics widget).

Implementation Brief

  • In assets/sass/components/global/_googlesitekit-table.scss:
    • Add styling for .googlesitekit-table .googlesitekit-table__body-item-content span for a max viewport width of $bp-tablet to the following:

      display: block;
      overflow: hidden;
      text-overflow: ellipsis;
      
      • This is similar to what is set for .googlesitekit-table .googlesitekit-table__body-item-content .googlesitekit-cta-link.

Test Coverage

  • No tests need to be added/updated.
  • Update any failing VRT references if required.

QA Brief

  • Follow aforementioned steps to reproduce and verify that queries don't overflow the table column.

Changelog entry

  • Fix bug that caused "Top search queries" widget to overflow on small screens.
@techanvil techanvil added Module: Search Console Search Console module related issues P1 Medium priority Type: Bug Something isn't working labels Mar 21, 2024
@techanvil techanvil changed the title Search queries in the "Top search queries" widget are overflowing at on the shared dashboard narrow viewports Search queries in the "Top search queries" widget are overflowing on the shared dashboard at narrow viewports Mar 21, 2024
@nfmohit nfmohit assigned nfmohit and unassigned nfmohit Mar 22, 2024
@eugene-manuilov eugene-manuilov self-assigned this Mar 26, 2024
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Mar 26, 2024
@mxbclang mxbclang added the Team S Issues for Squad 1 label Apr 1, 2024
@eugene-manuilov eugene-manuilov self-assigned this Apr 10, 2024
@eugene-manuilov eugene-manuilov removed their assignment Apr 10, 2024
@10upsimon 10upsimon assigned 10upsimon and unassigned 10upsimon Apr 12, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Apr 15, 2024
@mohitwp mohitwp self-assigned this Apr 16, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Apr 17, 2024

QA Update ✅

  • Tested on dev environment.
  • Verified when viewing the "Top search queries" widget on the shared dashboard at narrow viewports, long search queries not overflow the clicks and impressions metrics, and instead be truncated with ellipses (similarly to the "Top performing keywords" Key Metrics widget).

Latest:

image

Develop :

image

image

@mohitwp mohitwp removed their assignment Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Search Console Search Console module related issues P1 Medium priority Team S Issues for Squad 1 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants