Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check for Ads Conversion ID added via GTM #8513

Closed
1 task
mxbclang opened this issue Apr 10, 2024 · 10 comments
Closed
1 task

No check for Ads Conversion ID added via GTM #8513

mxbclang opened this issue Apr 10, 2024 · 10 comments
Labels
Module: Ads Google Ads module related issues P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@mxbclang
Copy link

mxbclang commented Apr 10, 2024

Feature Description

As reported by @jamesozzie in Ads Module Bug Bash:

image

If following the steps to add Ads Conversion tracking via GTM, it's possible to have both a SK inserted tacking ID and a GTM added tracking tag for a site.

Tested via adding an Ads Conversion Tracking ID manually, on a site that already has the Ads module successfully connected.

If feasible, add a notice within the Ads module, to mention that an existing tag was found - similar to how we do it for GA.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@mxbclang mxbclang added P1 Medium priority Type: Enhancement Improvement of an existing feature Module: Ads Google Ads module related issues Team S Issues for Squad 1 labels Apr 10, 2024
@eclarke1 eclarke1 added the Next Up Issues to prioritize for definition label Apr 22, 2024
@aaemnnosttv aaemnnosttv removed the Next Up Issues to prioritize for definition label Apr 29, 2024
@jimmymadon
Copy link
Collaborator

@jamesozzie (Although the questions below are mainly for @aaemnnosttv )

If feasible, add a notice within the Ads module, to mention that an existing tag was found - similar to how we do it for GA.

As mentioned in this (long) comment, since we moved to GA4, we no longer warn the user when a GTM container contains a "Google Tag (Measurement ID)" that points to the same Web Datastream selected within Google Analytics within the plugin. This functionality was removed from the plugin when we moved from UA to GA4 because:

  1. Having 2 duplicated tags inserted on a site do not duplicate the data / events in GA4.
  2. Fetching the web datastream connected to a Google Tag is not straightforward based on the current Analytics API.

Question 1: Are we sure that having the Ads Conversion ID inserted twice onto the site, via GTM and via Ads does not have any unfortunate side effects?

The only "GTM-GA4" integration we do now is that when GA4 is not connected in the plugin, and if the user connects Tag Manager and selects a GTM container whose current live version has "any valid" Google Tag ID, then we show a message.
This message simply encourages the user to set up GA4 within Site Kit.

Screenshot 2024-05-22 at 00 30 30

Question 2: Do we want to encourage the user to "set up Ads" like above if we do find an Ads Conversion ID in the currently selected GTM container?

@eclarke1
Copy link
Collaborator

Does this have to be @aaemnnosttv answering here, or can we loop in @tofumatt or @eugene-manuilov as Squad 1 leads?

@jimmymadon
Copy link
Collaborator

Sure - @tofumatt and @eugene-manuilov can guide us here too.

@eclarke1
Copy link
Collaborator

eclarke1 commented Jun 5, 2024

This is the last issue in the Ads Module epic, do we feel this is still needed? If so, can we move it through so we can get the epic closed out please

@binnieshah binnieshah added the Next Up Issues to prioritize for definition label Jun 6, 2024
@eugene-manuilov
Copy link
Collaborator

Question 1: Are we sure that having the Ads Conversion ID inserted twice onto the site, via GTM and via Ads does not have any unfortunate side effects?

I think the only way to answer this question is to try it and see whether we get duplicate events tracked when we have conversion tracking enabled via GTM and via Ads. @jamesozzie, can you try it using your setup?

Question 2: Do we want to encourage the user to "set up Ads" like above if we do find an Ads Conversion ID in the currently selected GTM container?

@aaemnnosttv, what do you think? I think this question is for you.

@jimmymadon
Copy link
Collaborator

Question 2: Do we want to encourage the user to "set up Ads" like above if we do find an Ads Conversion ID in the currently selected GTM container?

On our AC sync yesterday, @aaemnnosttv decided not to at this stage since there is not much value in connecting Ads via just the conversion ID for now.

As for Question 1, @jamesozzie will have a look.

@binnieshah
Copy link
Collaborator

@jamesozzie please could you review this?

@jamesozzie
Copy link
Collaborator

@jimmymadon @binnieshah Just to confirm I don't see any double tracking applied or issues with double tracking.

In these tests I ensured all users are included in reporting within SK. I didn't in this case check various events. Happy to do so if you let me know of any specific events you'd like me to check @eugene-manuilov

@eugene-manuilov
Copy link
Collaborator

Thanks, @jamesozzie. So, looks like here is nothing to do for us. Going to close this ticket.

@jamesozzie
Copy link
Collaborator

Sounds good @eugene-manuilov.

Note that I didn't check any click through from Google Ads directing me to a test website, I don't have Google Ads running for ads sites. Landing on a test website using Site Kit, with a Ads tag placed by both Site Kit and by GTM could potentially result in skewed data, I'm not sure. My tests were basic events, internal and external page clicks. Happy to test further, while I'll also add for discussion in our sync with @aaemnnosttv

@eclarke1 eclarke1 removed the Next Up Issues to prioritize for definition label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Ads Google Ads module related issues P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

8 participants