-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Ads module setup success banner notification has incorrect "Got it" CTA link color #8514
Comments
Since this is a very small issue and AC, I also added IB and moved it to the IBR directly |
IB ✅ |
QA Update ✅
|
While this technically the correct concrete value, we should reference the correct token that is used in the design rather than its underlying value. The design calls for
We can address this in a follow up, as there is another such instance to correct as well. |
Bug Description
As reported by @10upsimon in Ads Module Bug Bash:
The link color in the product is gray vs. green in the Figma designs:
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/sass/components/dashboard/_googlesitekit-subtle-notification.scss
.mdc-button
selector, apply the color of$c-site-kit-sk-600
Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: