Ads conversion ID not output when connected via PAX

[aaemnnosttv]

Bug Description

In #8580 we modified the tagging logic to support the new paxConversionID if present. However, a regression was introduced due to a flaw in the QA instructions.

Steps to reproduce

1. Setup Ads via PAX
2. Check site front end for gtag
3. Note that AW- tag will not be present in HTML markup

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Upon successful connection of the Ads module via PAX, the conversion tracking ID shown in the module settings should be present in the gtag config on the page

Implementation Brief

• Update Modules\Ads\Tag_Guard to accept the Tag's tag_id as a parameter instead of module settings, then validate that the given ID appears valid rather than checking the same fields in the settings since the tag ID is already selected at this point. This guard is primarily intended to implement logic based on other settings (e.g. useSnippet) which don't exist for Ads yet. We can potentially rename the guard class here as well if we want to keep things consistent with other modules and Tag_Guard specific to module settings.

Test Coverage

• Update coverage for the change to the guard

QA Brief

• Setup Ads via PAX:
  • Check the site's front end for gtag
  • Validate that the AW- aspect of the above tag (i.e the tag ID) matches the PAX Conversion ID value in Ads settings

Changelog entry

• Ensure conversion ID is output when Ads module is connected by PAX.

[tofumatt]

IB ✅

[wpdarren]

QA Update: ✅

Verified:

• The AW- aspect of the tag matches the PAX Conversion ID value in Ads settings.
  • Tested with Ads module / PAX only.
  • Tested with Ads module / PAX and Analytics
  • Tested with Ads module / PAX and Analytics and AMP activated.

Screenshots