Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request additional scope when connecting Ads via PAX #8792

Closed
1 task done
aaemnnosttv opened this issue Jun 4, 2024 · 2 comments
Closed
1 task done

Request additional scope when connecting Ads via PAX #8792

aaemnnosttv opened this issue Jun 4, 2024 · 2 comments
Labels
Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Jun 4, 2024

Feature Description

The Ads module requires a new OAuth scope when connecting via PAX for the purpose of providing in-product support/feedback.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Ads module should request an additional OAuth scope under the same conditions that it requests the adwords scope:
    https://www.googleapis.com/auth/supportcontent
    

Implementation Brief

  • Update \Google\Site_Kit\Modules\Ads::get_scopes to include the additional scope

Test Coverage

  • Update coverage for the method

QA Brief

  • Ensure the paxAds feature flag is enabled.
  • Reset Site Kit or set up a new site and proceed to connect the Ads module. Check that the additional scope (Support Content) is requested within the Google Auth screen.

Changelog entry

  • Add new OAuth scope to Ads module.
@aaemnnosttv aaemnnosttv added P0 High priority Type: Enhancement Improvement of an existing feature Module: Ads Google Ads module related issues Team S Issues for Squad 1 labels Jun 4, 2024
@jimmymadon jimmymadon self-assigned this Jun 4, 2024
@jimmymadon jimmymadon removed their assignment Jun 4, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Jun 4, 2024
@mohitwp mohitwp self-assigned this Jun 5, 2024
@aaemnnosttv
Copy link
Collaborator Author

This needs a follow up since the implementation only requires the scope when Ads does, but this misses the scenario when the Ads scope is first requested which is invoked on the client here

additionalScopes: [ ADWORDS_SCOPE ],

Sending back for a quick follow-up 👍

@wpdarren
Copy link
Collaborator

wpdarren commented Jun 7, 2024

QA Update: ✅

Verified:

  • The additional scope (Support data) is requested within the Google Auth screen.
  • The error reported previously for the scenario when the Ads scope is first requested does not occur. I am able to complete the oAuth and no errors appear on the setup screen.
Screenshots

image
image

@wpdarren wpdarren removed their assignment Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

7 participants