Copy on Enhanced Conversion Tracking Toggle for Analytics Module Needs Changing

[wpdarren]

Bug Description

As reported in Asana on the bug bashing by @kelvinballoo

The copy on the Analytics module edit mode is incorrect when comparing it to the Figma designs.

Based on Figma, it should be:
Conversion tracking is used for tracking additional conversion-related events via Analytics

Currently it reads:
Conversion tracking allows you to measure additional events on your site from other plugins that Site Kit integrates with to optimize your campaign performance. Learn more

Please note that there isn't a learn more link in the figma designs but from the conversation in Asana, it should be added.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

*ConversionTrackingToggle component should render copy dynamically. It should show:

• Conversion tracking is used for tracking additional conversion-related events via Analytics when on Analytics module
• Currently used copy Conversion tracking allows you to measure additional events on your site from other plugins that Site Kit integrates with to optimize your campaign performance. Learn more when on Ads module

Implementation Brief

• Update assets/js/components/conversion-tracking/ConversionTrackingToggle.js
  • Render the children instead of currently hardcoded content

    site-kit-wp/assets/js/components/conversion-tracking/ConversionTrackingToggle.js

    Lines 103 to 120 in 817317d

    	{ createInterpolateElement(
    	__(
    	'Conversion tracking allows you to measure additional events on your site from other plugins that Site Kit integrates with to optimize your campaign performance. <a>Learn more</a>',
    	'google-site-kit'
    	),
    	{
    	a: (
    	<Link
    	href={ conversionTrackingDocumentationURL }
    	external
    	aria-label={ __(
    	'Learn more about conversion tracking',
    	'google-site-kit'
    	) }
    	/>
    	),
    	}
    	) }

• Update assets/js/modules/ads/components/settings/SettingsForm.js
  • Use the content previously present in the ConversionTrackingToggle component and use it as a wrapper, to add the content element as child
• Update assets/js/modules/analytics-4/components/settings/SettingsForm.js
  • Use the content referenced in the AC for Analytics module and add it as translatable string wrapped under ConversionTrackingToggle component

Test Coverage

• Update any failing VRT

QA Brief

• Set up Site Kit with the Analytics and Ads modules enabled.
• Visit Site Kit Settings and open the Analytics' modules settings, then click "Edit" to open the edit mode
  • Ensure the text underneath the "Enhanced Conversion Tracking" toggle reads: Conversion tracking is used for tracking additional conversion-related events via Analytics
• Visit Site Kit Settings and open the Ads' modules settings, then click "Edit" to open the edit mode
  • Ensure the text underneath the "Enhanced Conversion Tracking" toggle reads: _ Conversion tracking allows you to measure additional events on your site from other plugins that Site Kit integrates with to optimize your campaign performance. Learn more_

Changelog entry

• Update copy for the Enhanced Conversion Tracking toggle to be different for the Analytics module.

[zutigrm]

Since it is a very straightforward issue, I added IB at the same time as AC

[eugene-manuilov]

@zutigrm let's use children instead of content.

[zutigrm]

@eugene-manuilov IB updated

[eugene-manuilov]

Thanks. IB ✔️

[mohitwp]

QA Update ✅

• Tested on dev environment.
• Verified that Analytics copy updated to Conversion tracking is used for tracking additional conversion-related events via Analytics .Verified the Ads module copy - the text underneath the "Enhanced Conversion Tracking" toggle reads: _ Conversion tracking allows you to measure additional events on your site from other plugins that Site Kit integrates with to optimize your campaign performance. Learn more_`