Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance between New badge and text should be 14px instead of 6px. #8861

Closed
1 task done
kelvinballoo opened this issue Jun 12, 2024 · 2 comments
Closed
1 task done
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@kelvinballoo
Copy link
Collaborator

kelvinballoo commented Jun 12, 2024

Bug Description

Distance between New badge and text should be 14px instead of 6px.

Steps to reproduce

  1. Turn on audience segmentation featured flag
  2. Review the 'New' badge at the 'CTA Groups' CTA.

Screenshots

Details
Implementation: 6px
Screenshot 2024-06-11 at 22 05 59

Figma: 14px
Screenshot 2024-06-11 at 22 05 10

Additional Context

  • PHP Version: 8.0
  • Browser: Chrome
  • Plugin Version: 1.129.0
  • Device: MacOS Sonoma on MacbookPro

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • There should be a 14px gap between the title of a widget area and its "New" badge.
  • In concrete terms, this should apply to the Audiences Widget Area as the first widget area with a "New" badge, as well as any subsequently added widget areas with a badge

Implementation Brief

  • Update assets/sass/widgets/_widget-area.scss, add a new block targeting .googlesitekit-widget-area-header .googlesitekit-new-badge, set the margin-left to 14px.

Test Coverage

  • Update any failing VRTs.

QA Brief

Changelog entry

  • Improve margins between "New" badge and text.
@ivonac4 ivonac4 added the Team M Issues for Squad 2 label Jun 17, 2024
@techanvil techanvil self-assigned this Jun 18, 2024
@techanvil techanvil added P1 Medium priority Type: Enhancement Improvement of an existing feature labels Jun 18, 2024
@techanvil techanvil removed their assignment Jun 20, 2024
@benbowler benbowler assigned benbowler and unassigned benbowler Jun 24, 2024
@nfmohit nfmohit self-assigned this Jun 24, 2024
@nfmohit
Copy link
Collaborator

nfmohit commented Jun 24, 2024

IB ✅

@nfmohit nfmohit removed their assignment Jun 24, 2024
@binnieshah binnieshah added Team S Issues for Squad 1 and removed Team M Issues for Squad 2 labels Jun 26, 2024
@benbowler benbowler self-assigned this Jul 3, 2024
@benbowler benbowler removed their assignment Jul 3, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Jul 4, 2024
@mohitwp mohitwp self-assigned this Jul 5, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Jul 5, 2024

QA Update ✅

  • Tested on dev environment.
  • Verified the gap between the title of a widget area and its "New" badge is 14px.

image

@mohitwp mohitwp removed their assignment Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

9 participants