-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tracking To The Conversion Tracking Toggle #8894
Comments
@aaemnnosttv please could you confirm what could be used for the event name used for tracking? We can then complete the AC for this, thanks! |
from Slack: I've added the events to our sheet where these our defined to a new section for "Enhanced Conversion Tracking". It should be all we need for defining 8894 |
@zutigrm assigning back to you in AC for now as we have internal ongoing discussions at present to decide on the event names for the modal actions as well. I'll udpate you once we have them and we can update the AC and return to me for ACR. |
QA Update: ✅Verified: Checked the events for Ads as per QAB, but also made sure Analytics toggle triggered the events too.
|
Feature Description
The Enhanced Conversion Tracking toggle should track internal events following the example of other toggles.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
${viewContext}
ect_enable
ect_disable
ect_view_modal
ect_confirm_disable
ect_cancel_disable
Implementation Brief
assets/js/components/conversion-tracking/ConversionTrackingToggle.js
assets/js/components/consent-mode/ConsentModeSwitch.js
for an example as it has similar events/behaviourSwitch
, inonClick
underisConversionTrackingEnabled
check trackect_disable
, and inelse
condition check trackect_enable
ConfirmDisableConversionTrackingDialog
componentonConfirm
callback, include event tracking forect_confirm_disable
onCancel
callback include event tracking forect_cancel_disable
assets/js/components/conversion-tracking/ConfirmDisableConversionTrackingDialog.js
useMount
hook and trackect_view_modal
event nameTest Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: