Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tracking To The Conversion Tracking Toggle #8894

Closed
3 tasks done
zutigrm opened this issue Jun 18, 2024 · 4 comments
Closed
3 tasks done

Add Tracking To The Conversion Tracking Toggle #8894

zutigrm opened this issue Jun 18, 2024 · 4 comments
Labels
P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@zutigrm
Copy link
Collaborator

zutigrm commented Jun 18, 2024

Feature Description

The Enhanced Conversion Tracking toggle should track internal events following the example of other toggles.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Event category for all events should be ${viewContext}
  • When enhanced conversion tracking toggle is switched, an event should be tracked in following way:
    • When the toggle is enabled the event name to track should be ect_enable
    • When the toggle is disabled the event name to track should be ect_disable
  • When the disable modal is shown - upon trying to disable the toggle:
    • When the modal is in view, track an event with name ect_view_modal
    • When clicking the confirm button (to continue with disabling the tracking) in modal, track an event with name ect_confirm_disable
    • When canceling the modal (choosing not to disable the conversion tracking) track an event with name ect_cancel_disable

Implementation Brief

  • All events should have category name defined in AC
  • Update assets/js/components/conversion-tracking/ConversionTrackingToggle.js
    • You can check assets/js/components/consent-mode/ConsentModeSwitch.js for an example as it has similar events/behaviour
    • In the main Switch, in onClick under isConversionTrackingEnabled check track ect_disable, and in else condition check track ect_enable
    • Update ConfirmDisableConversionTrackingDialog component
      • In onConfirm callback, include event tracking for ect_confirm_disable
      • In onCancel callback include event tracking for ect_cancel_disable
  • Update assets/js/components/conversion-tracking/ConfirmDisableConversionTrackingDialog.js
    • Add useMount hook and track ect_view_modal event name

Test Coverage

  • No updates needed

QA Brief

  • Setup Site Kit and connect Ads module
  • Go to settings edit screen of Ads module
  • Verify that events listed in the AC are tracked as defined

Changelog entry

  • Added events tracking to the conversion tracking toggle.
@zutigrm zutigrm added Type: Enhancement Improvement of an existing feature Team S Issues for Squad 1 labels Jun 18, 2024
@eclarke1 eclarke1 added the P0 High priority label Jun 18, 2024
@binnieshah
Copy link
Collaborator

@aaemnnosttv please could you confirm what could be used for the event name used for tracking? We can then complete the AC for this, thanks!

@aaemnnosttv aaemnnosttv removed their assignment Jun 20, 2024
@binnieshah
Copy link
Collaborator

from Slack: I've added the events to our sheet where these our defined to a new section for "Enhanced Conversion Tracking". It should be all we need for defining 8894

@binnieshah binnieshah assigned binnieshah and zutigrm and unassigned binnieshah Jun 20, 2024
@zutigrm zutigrm removed their assignment Jun 21, 2024
@10upsimon
Copy link
Collaborator

@zutigrm assigning back to you in AC for now as we have internal ongoing discussions at present to decide on the event names for the modal actions as well. I'll udpate you once we have them and we can update the AC and return to me for ACR.

@zutigrm zutigrm assigned 10upsimon and unassigned zutigrm Jun 21, 2024
@10upsimon 10upsimon removed their assignment Jun 21, 2024
@zutigrm zutigrm assigned zutigrm and 10upsimon and unassigned zutigrm Jun 21, 2024
@10upsimon 10upsimon removed their assignment Jun 21, 2024
@zutigrm zutigrm mentioned this issue Jun 21, 2024
18 tasks
@zutigrm zutigrm removed their assignment Jun 21, 2024
@benbowler benbowler assigned benbowler and unassigned benbowler Jun 24, 2024
@wpdarren wpdarren self-assigned this Jun 24, 2024
@wpdarren
Copy link
Collaborator

wpdarren commented Jun 24, 2024

QA Update: ✅

Verified:

Checked the events for Ads as per QAB, but also made sure Analytics toggle triggered the events too.

  • When enhanced conversion tracking toggle is switched, an event is tracked in following ways:
    • When the toggle is enabled the event name to track is ect_enable
    • When the toggle is disabled the event name to track is ect_disable
  • When the disable modal is shown - upon trying to disable the toggle:
    • When the modal is in view, track an event with name ect_view_modal
    • When clicking the confirm button in modal, track an event with name ect_confirm_disable
    • When canceling the modal track an event with name ect_cancel_disable
Screenshots

image
image
image
image
image

@wpdarren wpdarren removed their assignment Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

8 participants