Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the design of the Key Metrics setup CTA banner. #8895

Open
2 tasks done
techanvil opened this issue Jun 18, 2024 · 10 comments
Open
2 tasks done

Update the design of the Key Metrics setup CTA banner. #8895

techanvil opened this issue Jun 18, 2024 · 10 comments
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature UX Issues that require UX input

Comments

@techanvil
Copy link
Collaborator

techanvil commented Jun 18, 2024

Feature Description

The current Key Metrics setup CTA banner looks like this:

Screenshot 2024-07-25 at 19 20 32

But the dismiss CTA is in the bottom of the banner, which isn’t consistent with our new banners.

We have a new Figma design for the Key Metrics setup CTA banner:

image

This design should be applied to the banner in the plugin.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The
    function KeyMetricsSetupCTAWidget( { Widget, WidgetNull } ) {
    should be updated to match the new design in the Figma mockups for mobile, tablet, 960 specific screen design and desktop views.
  • Note that the "I'll pick metrics myself" secondary CTA should be moved to the footer of the new CTA, and renamed to the "Choose your own metrics", and the "Maybe later" in the current CTA should be moved to the secondary CTA next to "Get tailored metrics".

Implementation Brief

  • Edit assets/js/components/KeyMetrics/KeyMetricsCTAContent.js and assets/js/components/KeyMetrics/KeyMetricsSetupCTAWidget.js
    • Adapt the markup for new design - swapping the CTA's, adding new text in the footer, replacing the SVG image with the one in figma, etc.
    • Note that mobile version has different SVG, which should be rendered conditionally based on the breakpoint , instead of the main one
    • New footer layout might need some tweaks in layout
  • Update assets/sass/components/key-metrics/_googlesitekit-key-metrics-setup-cta.scss
    • Adjust the styling to match new design - areas like font size, new footer section, position of the graphic, etc

Test Coverage

  • Update VRT's

QA Brief

  • Setup Site Kit with Analytics module
  • Verify that setup key metrics widget is showing as per new figma designs across the screens
  • Select 2 key metrics, then disconnect Analytics module
  • Verify that small connect GA4 CTA is showing correctly (there is no new design for this, it should look correctly across the screens)
  • Setup Analytics module and select 4 GA4 key metrics
  • Disconnect the module
  • Verify that big Analytics disconnected CTA is showing correctly across the screens - it follows same layout as default setup CTA just with different content, and footer CTA should be maybe later instead of select your own metrics

Changelog entry

  • Update the design of the Key Metrics setup CTA banner.
@techanvil techanvil added P1 Medium priority Type: Enhancement Improvement of an existing feature labels Jun 18, 2024
@tofumatt tofumatt self-assigned this Jul 23, 2024
@tofumatt tofumatt added the UX Issues that require UX input label Jul 23, 2024
@tofumatt
Copy link
Collaborator

As mentioned in Slack, this needs mobile designs/guidance before we can move it to IB, so leaving it in AC for now.

@tofumatt tofumatt removed their assignment Jul 25, 2024
@tofumatt
Copy link
Collaborator

Mobile designs are ready so moved this to IB 👍🏻

@binnieshah binnieshah added Team S Issues for Squad 1 Next Up Issues to prioritize for definition labels Jul 26, 2024
@zutigrm zutigrm assigned zutigrm and unassigned zutigrm Jul 26, 2024
@binnieshah binnieshah added Next Up Issues to prioritize for definition and removed Next Up Issues to prioritize for definition labels Jul 26, 2024
@eugene-manuilov eugene-manuilov self-assigned this Jul 26, 2024
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Jul 26, 2024
@zutigrm zutigrm self-assigned this Jul 29, 2024
@zutigrm zutigrm removed the Next Up Issues to prioritize for definition label Jul 30, 2024
@zutigrm
Copy link
Collaborator

zutigrm commented Jul 31, 2024

Parking it in the meantime until it gets a sprint number, since I picked it up by mistake

@eugene-manuilov eugene-manuilov removed their assignment Sep 25, 2024
@zutigrm
Copy link
Collaborator

zutigrm commented Sep 25, 2024

Hi @sigal-teller , since this banner has a bit longer content, and we aim to cover desktop layout for screens starting at 960px and over, currently it's existing desktop sizes are too crowded, causing the banner to grow in height, and hence the Graphic to look out of place as it doesn't fit correctly in that crowded space. At the moment it is showing tablet layout on these screens. Would it be possible to add new screen with adjusted desktop layout for 960px screen width?

Current desktop layout works fine for screens starting at 1280px and over so that style will remain for these screens, new adjustment would be only for specific screen sizes between 960px to bellow 1280px.

cc: @eugene-manuilov

@sigal-teller
Copy link
Collaborator

Hi @zutigrm I assume you meant a total screen width of 960px, which means that when deducting the WP bar, there is a net width of 800px for the dashboard. It is possible to have a version of the desktop design like here.
In this width it looks better then the tablet design.
By the way, why aren't we implementing the banner design that I created for ACR already? It is very similar only includes a slightly different illustration and additional explanatory text, which can actually fit for KMW as well. This new design for KMW was created before, but it was a long time ago, so Im wondering if we're implementing it now why not use the ACR banner which will replace it?

@zutigrm
Copy link
Collaborator

zutigrm commented Sep 25, 2024

@sigal-teller Yes perfect, that's nice solution.

By the way, why aren't we implementing the banner design that I created for ACR already? It is very similar only includes a slightly different illustration and additional explanatory text

That's a good point, thanks. Since the text is not mentioning directly the ACR - because this banner will be shown to all users, not hidden behind feature flag, I will adjust the current implementation to include new graphic and text from the ACR figma file.

@sigal-teller
Copy link
Collaborator

@zutigrm ok great, so I'll create the design for this this width in the ACR Figma file as well

@zutigrm
Copy link
Collaborator

zutigrm commented Sep 25, 2024

@sigal-teller awesome, thank you!

@sigal-teller
Copy link
Collaborator

@zutigrm Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature UX Issues that require UX input
Projects
None yet
Development

No branches or pull requests

7 participants