-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the design of the Key Metrics setup CTA banner. #8895
Comments
As mentioned in Slack, this needs mobile designs/guidance before we can move it to IB, so leaving it in AC for now. |
Mobile designs are ready so moved this to IB 👍🏻 |
IB ✔️ |
Parking it in the meantime until it gets a sprint number, since I picked it up by mistake |
Hi @sigal-teller , since this banner has a bit longer content, and we aim to cover desktop layout for screens starting at 960px and over, currently it's existing desktop sizes are too crowded, causing the banner to grow in height, and hence the Graphic to look out of place as it doesn't fit correctly in that crowded space. At the moment it is showing tablet layout on these screens. Would it be possible to add new screen with adjusted desktop layout for 960px screen width? Current desktop layout works fine for screens starting at 1280px and over so that style will remain for these screens, new adjustment would be only for specific screen sizes between 960px to bellow 1280px. cc: @eugene-manuilov |
Hi @zutigrm I assume you meant a total screen width of 960px, which means that when deducting the WP bar, there is a net width of 800px for the dashboard. It is possible to have a version of the desktop design like here. |
@sigal-teller Yes perfect, that's nice solution.
That's a good point, thanks. Since the text is not mentioning directly the ACR - because this banner will be shown to all users, not hidden behind feature flag, I will adjust the current implementation to include new graphic and text from the ACR figma file. |
@zutigrm ok great, so I'll create the design for this this width in the ACR Figma file as well |
@sigal-teller awesome, thank you! |
@zutigrm Done. |
Feature Description
The current Key Metrics setup CTA banner looks like this:
But the dismiss CTA is in the bottom of the banner, which isn’t consistent with our new banners.
We have a new Figma design for the Key Metrics setup CTA banner:
This design should be applied to the banner in the plugin.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
site-kit-wp/assets/js/components/KeyMetrics/KeyMetricsSetupCTAWidget.js
Line 57 in dc89f6c
Implementation Brief
assets/js/components/KeyMetrics/KeyMetricsCTAContent.js
andassets/js/components/KeyMetrics/KeyMetricsSetupCTAWidget.js
assets/sass/components/key-metrics/_googlesitekit-key-metrics-setup-cta.scss
Test Coverage
QA Brief
Analytics disconnected
CTA is showing correctly across the screens - it follows same layout as default setup CTA just with different content, and footer CTA should bemaybe later
instead ofselect your own metrics
Changelog entry
The text was updated successfully, but these errors were encountered: