-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show the Audiences Widget Area when it's turned off in Settings #9065
Comments
IB :heavy |
QA Update
|
Thanks @kelvinballoo, that's a good point. Initially, the audience settings were part of the Analytics module so we needed Analytics to be active in order to show the switch, but now we've moved the settings out to the user scope, we can show the switch even when Analytics is not active/connected. It's out of scope for this issue though, so please can you create a new one for it? |
QA Update ✅Thanks @techanvil . As for this ticket, it's good to be moved to approval as it's working well.
|
Feature Description
Ensure the Audiences Widget Area on the dashboard is hidden when the "Display visitor groups in dashboard" switch is toggled off in the Settings section.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
During the widget area registration here, pass the
filterActiveWidgets
function as the propertysettings
property toregisterWidgetArea
function. It accepts two argumentsselect
andareaWidgets
filterActiveWidgets
function check if audience segmentation widget is hidden usingareaWidgets
.Test coverage
No additional test required.
QA Brief
Enable Groups
CTA.Site Kit > Settings
, turn offDisplay visitor groups in dashboard
toggle.Changelog entry
The text was updated successfully, but these errors were encountered: