Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversionReporting Feature Flag #9152

Closed
1 task
10upsimon opened this issue Aug 7, 2024 · 3 comments
Closed
1 task

Add conversionReporting Feature Flag #9152

10upsimon opened this issue Aug 7, 2024 · 3 comments
Labels
P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@10upsimon
Copy link
Collaborator

10upsimon commented Aug 7, 2024 •
edited by tofumatt
Loading

Feature Description

A new feature flag, conversionReporting, is required in order to gate work related to the Analytics Conversion Reporting epic.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • A new conversionReporting feature flag is present in the code base
  • Said new conversionReporting feature flag is selectable via the Site Kit Tester plugin

Implementation Brief

  • Update feature-flags.json, add conversionReporting to the list

Test Coverage

  • No updates needed

QA Brief

  • Verify that conversionReporting feature flag is present using tester plugin

Changelog entry

  • Add conversionReporting feature flag to plugin.
@10upsimon 10upsimon added Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature labels Aug 7, 2024
@binnieshah binnieshah added the Next Up Issues to prioritize for definition label Aug 13, 2024
@10upsimon 10upsimon assigned 10upsimon and unassigned 10upsimon Aug 14, 2024
@eugene-manuilov eugene-manuilov self-assigned this Aug 14, 2024
@eugene-manuilov
Copy link
Collaborator

AC ✔️

@eugene-manuilov eugene-manuilov removed their assignment Aug 14, 2024
@zutigrm zutigrm assigned zutigrm and unassigned zutigrm Aug 16, 2024
@eugene-manuilov eugene-manuilov self-assigned this Aug 19, 2024
@binnieshah binnieshah added the P0 High priority label Aug 19, 2024
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Aug 19, 2024
@zutigrm zutigrm self-assigned this Aug 20, 2024
@binnieshah binnieshah removed the Next Up Issues to prioritize for definition label Aug 20, 2024
@zutigrm zutigrm mentioned this issue Aug 20, 2024
Merged
18 tasks
@zutigrm zutigrm removed their assignment Aug 20, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Aug 20, 2024
@wpdarren wpdarren self-assigned this Aug 21, 2024
@wpdarren
Copy link
Collaborator

QA Update: ✅

Verified:

  • The conversionReporting feature flag is present using tester plugin.
  • I was able to enable the feature flag with no errors.
  • Refreshed tester plugin settings and the feature flag stayed enabled

image

@wpdarren wpdarren removed their assignment Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@tofumatt @eugene-manuilov @aaemnnosttv @zutigrm @10upsimon @wpdarren @binnieshah