Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Edit in Reader Revenue Manager" link for the RRM module #9192

Closed
3 tasks
nfmohit opened this issue Aug 13, 2024 · 2 comments
Closed
3 tasks

Add "Edit in Reader Revenue Manager" link for the RRM module #9192

nfmohit opened this issue Aug 13, 2024 · 2 comments
Labels
Module: RRM Reader Revenue Manager module related issues P1 Medium priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@nfmohit
Copy link
Collaborator

nfmohit commented Aug 13, 2024

Feature Description

As pointed out kindly by @techanvil here, similar to other modules, an "Edit in Reader Revenue Manager" link should be added to the RRM module's settings view screen.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • An "Edit in Reader Revenue Manager" external link should be added to the settings view screen of the Reader Revenue Manager module.
    • The link text should technically be "Edit publication in Reader Revenue Manager", but "publication" should be visually hidden, only accessible to screen readers.
  • This should be added just to the right-side of the publication ID, and look similar to how the "Edit in Analytics" external icon exists for the same screen of the Analytics module.
  • The link should open the publication details page in the Publisher Center in a new tab.

Implementation Brief

  • Update assets/js/modules/reader-revenue-manager/components/settings/SettingsView.js:
    • Adjacent to the existing div.googlesitekit-settings-module__meta-item element, add the external link as mentioned in the ACs in a new div.googlesitekit-settings-module__meta-item.googlesitekit-settings-module__meta-item--data-only element, similar to how the "Edit in Analytics" link is added in assets/js/modules/analytics-4/components/settings/SettingsView.js.
    • The VisuallyHidden component should be used to prevent the "publication" text from being visible according to the ACs.

Test Coverage

  • No tests need to be added/updated.
  • Update VRT references if required.

QA Brief

  • Connect RRM module.
  • The link, as defined it ACs should appear in Settings View of RRM module. Clicking the link should open the publication details in Reader Revenue Manager.

Changelog entry

  • Add an "Edit in Reader Revenue Manager" link to the RRM module's settings view screen.
@nfmohit nfmohit added P1 Medium priority Type: Enhancement Improvement of an existing feature Team M Issues for Squad 2 Module: RRM Reader Revenue Manager module related issues labels Aug 13, 2024
@nfmohit nfmohit self-assigned this Aug 13, 2024
@nfmohit nfmohit assigned nfmohit and unassigned nfmohit Aug 15, 2024
@nfmohit nfmohit removed their assignment Aug 23, 2024
@kuasha420 kuasha420 self-assigned this Aug 27, 2024
@kuasha420
Copy link
Contributor

IB ✔️

@kelvinballoo
Copy link
Collaborator

QA Update ✅

This was verified good. Moving ticket to approval.

  • An "Edit in Reader Revenue Manager" external link was added to the settings view screen of the Reader Revenue Manager module.

    • This appeared just to the right-side of the publication ID, and looks similar to how the "Edit in Analytics" external icon exists for the same screen of the Analytics module.
    • The link opens the publication details page in the Publisher Center in a new tab.
    RRM.edit.tested.good.mov
  • The link text is technically "Edit publication in Reader Revenue Manager", but "publication" is visually hidden and is only accessible to screen readers.

    Edit.publication.voiceover.mov

@kelvinballoo kelvinballoo removed their assignment Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: RRM Reader Revenue Manager module related issues P1 Medium priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants