Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky AudienceSegmentationSetupCTAWidget test #9316

Open
5 tasks
techanvil opened this issue Sep 9, 2024 · 3 comments
Open
5 tasks

Fix flaky AudienceSegmentationSetupCTAWidget test #9316

techanvil opened this issue Sep 9, 2024 · 3 comments
Assignees
Labels
Module: Analytics Google Analytics module related issues P0 High priority QA: Eng Requires specialized QA by an engineer Sp Wk 2 Issues to be completed in the second week of the assigned sprint Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Sep 9, 2024

Feature Description

This test for the AudienceSegmentationSetupCTAWidget component has started failing sporadically in CI:

AudienceSegmentationSetupCTAWidget › CTA actions › should initialise the list of configured audiences when autoSubmit is set to true.

image

This has been seen in develop:

And in a run for a PR (it doesn't appear related to the changes for this PR):


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The above test for the AudienceSegmentationSetupCTAWidget component should pass every time, locally and in CI.

Implementation Brief

In assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupCTAWidget.test.js:

  • Locate to the should initialise the list of configured audiences when autoSubmit is set to true. test.
  • Increase the value passed to waitForTimeouts to 50.

In assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidget/index.test.js:

  • Locate to the should render correctly when there is partial data for Site Kit audiences test.
  • Increase the value passed to waitForTimeouts to 100.
  • Merge the POC PR that confirmed the tests pass consistently with the increased timeouts after multiple retries.

Test Coverage

  • No new tests are required for this change.

QA Brief

QA:Eng

  • Verify that the AudienceSegmentationSetupCTAWidget component test passes consistently, both locally and in CI.
  • Verify that the AudienceTilesWidget component test passes consistently, both locally and in CI.

Changelog entry

@techanvil techanvil added Module: Analytics Google Analytics module related issues P1 Medium priority Type: Enhancement Improvement of an existing feature P0 High priority and removed P1 Medium priority labels Sep 9, 2024
@benbowler benbowler self-assigned this Sep 25, 2024
@tofumatt
Copy link
Collaborator

This is failing almost all the time now:

Screenshot 2024-09-25 at 22 39 46

We should get this fixed as it's adding time to every review (needing to check to make sure this is the only test that's failing).

If there isn't an immediate solution we should ignore this test, since we already are, but then at least we can see the test run as green and immediately trust it during code review.

@tofumatt tofumatt added the Next Up Issues to prioritize for definition label Sep 25, 2024
@ivonac4 ivonac4 added Team M Issues for Squad 2 Sp Wk 2 Issues to be completed in the second week of the assigned sprint labels Sep 26, 2024
@benbowler benbowler removed their assignment Sep 26, 2024
@benbowler
Copy link
Collaborator

Un-assigning incase anyone can get to this before next week.

@hussain-t hussain-t self-assigned this Sep 27, 2024
@hussain-t hussain-t added the QA: Eng Requires specialized QA by an engineer label Sep 27, 2024
@hussain-t hussain-t removed their assignment Sep 27, 2024
@ivonac4 ivonac4 removed the Next Up Issues to prioritize for definition label Oct 1, 2024
@tofumatt tofumatt self-assigned this Oct 3, 2024
@tofumatt
Copy link
Collaborator

tofumatt commented Oct 3, 2024

IB ✅

@tofumatt tofumatt assigned hussain-t and unassigned tofumatt Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Analytics Google Analytics module related issues P0 High priority QA: Eng Requires specialized QA by an engineer Sp Wk 2 Issues to be completed in the second week of the assigned sprint Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants