Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tracking of the request's life cycle #238

Merged
merged 4 commits into from
Nov 20, 2018

Conversation

artikz
Copy link
Contributor

@artikz artikz commented Oct 31, 2018

Add request events listener which will be called on the request life
cycle events (queued, processing started, etc). Also add the ability to
associate data with the requests, without using other data structures,
which is useful when processing request life cycle events.

Add request events listener which will be called on the request life
cycle events (queued, processing started, etc). Also add the ability to
associate data with the requests, without using other data structures,
which is useful when processing request life cycle events.
src/main/java/com/android/volley/Request.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
src/test/java/com/android/volley/CacheDispatcherTest.java Outdated Show resolved Hide resolved
@jpd236 jpd236 requested a review from jjoslin November 9, 2018 16:33
src/test/java/com/android/volley/CacheDispatcherTest.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/Request.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/Request.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/Request.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/Request.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/Request.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
@artikz
Copy link
Contributor Author

artikz commented Nov 15, 2018

I think I addressed all the comments

Copy link
Collaborator

@jpd236 jpd236 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally seems okay to me. @jjoslin any further concerns on your side?

src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
src/main/java/com/android/volley/RequestQueue.java Outdated Show resolved Hide resolved
src/test/java/com/android/volley/CacheDispatcherTest.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants