-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save story before showing the preview #1122
Conversation
Size Change: +539 B (0%) Total Size: 868 kB
ℹ️ View Unchanged
|
Adding @miina as you worked on the document sidebar and save buttons. |
Looks like the unit tests are failing. EDIT: Looks like the PR is not finalized, misunderstood. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well - except for previewing converting every post to draft, which is definitely not per design.
4cc02c5
to
a87c1b4
Compare
@swissspidy ptal again. i think this is ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note on renaming Preview
until it's actually a Preview
, can be ignored though, works well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment on the preview failure dialog (though it's edge-case). Otherwise works really great!
Fixes: #1072.
This is a rather strange approach, but usually works ok. We open the popup with "about:blank", wait for the async operation to finish and then re-navigate the popup to the final URL. This way we do not bust the
window.open
timeout.TODO: