Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ord instances for integer wrappers e.g. U64 #148

Closed
jjl opened this issue Dec 3, 2022 · 2 comments
Closed

Ord instances for integer wrappers e.g. U64 #148

jjl opened this issue Dec 3, 2022 · 2 comments
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking

Comments

@jjl
Copy link

jjl commented Dec 3, 2022

It would be nice if they could be compared directly rather than having to .get() them before comparison. That would allow deriving Ord over structs using them that are in disk format.
@joshlf
Copy link
Member

joshlf commented Dec 3, 2022

If memory serves, I tried this when I initially introduced those wrappers, and it caused a lot of type inference issues. I'll take a stab at it again when I get a chance to confirm that that was the reason.

@joshlf joshlf added the blocking-next-release This issue should be resolved before we release on crates.io label Dec 3, 2022
@joshlf joshlf added the compatibility-breaking Changes that are (likely to be) breaking label Aug 12, 2023
@joshlf joshlf mentioned this issue Aug 20, 2023
Closed
@joshlf joshlf removed the blocking-next-release This issue should be resolved before we release on crates.io label Aug 25, 2023
@joshlf joshlf added compatibility-nonbreaking Changes that are (likely to be) non-breaking and removed compatibility-breaking Changes that are (likely to be) breaking labels Dec 4, 2023
@joshlf joshlf mentioned this issue Feb 20, 2024
Merged
@joshlf
Copy link
Member

joshlf commented May 3, 2024 •
edited
Loading

Closed in #915.

@joshlf joshlf closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjl @joshlf