Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v27.1.0 breaks compatibility w/ Psr\Log\LoggerInterface #306

Closed
metadke opened this issue Jun 12, 2017 · 2 comments
Closed

v27.1.0 breaks compatibility w/ Psr\Log\LoggerInterface #306

metadke opened this issue Jun 12, 2017 · 2 comments
Assignees

Comments

@metadke
Copy link

metadke commented Jun 12, 2017

If you set a custom logger w/ the with...Logger() function of the AdWordsSessionBuilder you will get a runtime exception later, because some inner implementation calls isHandling() on the implementation of Psr\Log\LoggerInterface which does not exist.

For example:

$myLogger = new  (class that implements Psr\Log\LoggerInterface) { ,,, };

$builder = (new AdWordsSessionBuilder())
  // ...
  ->withReportDownloaderLogger($myLogger)
  ->build();

PHP Fatal error: Call to undefined method MyLogger::isHandling() in vendor/googleads/googleads-php-lib/src/Google/AdsApi/Common/GuzzleLogMessageHandler.php on line 53

@fiboknacky fiboknacky self-assigned this Jun 12, 2017
@fiboknacky
Copy link
Member

Thanks for reporting. Will have a look.

@fiboknacky
Copy link
Member

This is fixed in v28.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants