Skip to content
This repository has been archived by the owner on Mar 1, 2022. It is now read-only.

smoke tests are failing #479

Closed
alexander-fenster opened this issue Jul 26, 2018 · 4 comments · Fixed by #481
Closed

smoke tests are failing #479

alexander-fenster opened this issue Jul 26, 2018 · 4 comments · Fixed by #481
Assignees

Comments

@alexander-fenster
Copy link
Contributor

#475 broke smoke tests, three invocations fail:

Failure:
Failed to generate java_gapic of /tmp/googleapis_smoketest/google/datastore/admin/artman_datastore_admin.yaml.
Failed to generate java_gapic of /tmp/googleapis_smoketest/google/longrunning/artman_longrunning.yaml.
Failed to generate gapic_config of /tmp/googleapis_smoketest/google/monitoring/artman_monitoring.yaml.

All three fail with the following in the log (available as CircleCI build artifact here):

�[35martman> �[36mCreating GapicOnlyClientPipeline.�[0m
�[35martman> �[31mTraceback (most recent call last):
  File "/artman/artman/cli/main.py", line 67, in main
    **pipeline_kwargs)
  File "/artman/artman/pipelines/pipeline_factory.py", line 53, in make_pipeline
    return cls(**kwargs)
  File "/artman/artman/pipelines/gapic_generation.py", line 80, in __init__
    GapicOnlyTaskFactory(**kwargs),
TypeError: object() takes no parameters

This is blocking automated releases. Can I ask you to take a look and fix, or reassign as appropriate?

Thanks!

@garrettjonesgoogle
Copy link
Member

java_gapic in artman_datastore_admin.yaml should not be GAPIC_ONLY. I am pushing an internal CL to switch it to GAPIC.

@garrettjonesgoogle
Copy link
Member

googleapis/gapic-generator#2169 in gapic-generator needs to be pulled in to fix the gapic_config artifact of artman_monitoring.yaml.

@alexander-fenster
Copy link
Contributor Author

OK so I'll update hashes for gapic-generator and googleapis and it might fix these two. What about artman_longrunning.yaml?

@garrettjonesgoogle
Copy link
Member

That is fixed in #480

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants