Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reduce integration test flakiness #807

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

amchiclet
Copy link
Contributor

@amchiclet amchiclet commented Mar 23, 2022

The test now retries when connecting to the metadata server.

Go 1.17 build constraint syntax was also added.

Tested by temporarily having presubmit also run the backoff tests.

The Golint check may fail because there is no .mod file. This is intentional and integration_test.sh does the module initialization.

Windows check may also fail but can be ignored (Windows is not supported).

@amchiclet amchiclet added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
@product-auto-label product-auto-label bot added the api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. label Mar 23, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #807 (c47b84c) into main (4cc74b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   69.55%   69.55%           
=======================================
  Files           7        7           
  Lines        1248     1248           
  Branches       53       53           
=======================================
  Hits          868      868           
  Misses        379      379           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc74b7...c47b84c. Read the comment docs.

@amchiclet amchiclet added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
@amchiclet amchiclet marked this pull request as ready for review March 23, 2022 18:42
@amchiclet amchiclet requested review from a team as code owners March 23, 2022 18:42
@amchiclet amchiclet marked this pull request as draft March 23, 2022 20:16
@amchiclet amchiclet added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
@amchiclet amchiclet marked this pull request as ready for review March 23, 2022 21:39
@amchiclet amchiclet merged commit 1772d79 into googleapis:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants