Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: methods returning Operation w/o operation_info are now allowed. #1047

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

kbandes
Copy link
Contributor

@kbandes kbandes commented Oct 28, 2021

Formerly, a method that returned google.longrunning.Operation but did not have the google.longrunning.operation_info extension was considered an error; but there are valid cases for this, particularly in the Operation service itself.
This change makes it acceptable to have a method like this. It is not treated as a long-running operation.

@kbandes kbandes requested a review from a team as a code owner October 28, 2021 17:07
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 28, 2021
Copy link
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just outrageously picky grammar nits in new comments.

tests/unit/schema/test_api.py Outdated Show resolved Hide resolved
gapic/schema/api.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants