Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F401 imported but unused #324

Closed
busunkim96 opened this issue Feb 27, 2020 · 3 comments
Closed

F401 imported but unused #324

busunkim96 opened this issue Feb 27, 2020 · 3 comments
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@busunkim96
Copy link
Contributor

More unused imports (but different from the ones in #169).

If the answer is "It's hard to get rid of these" I can live with that, but I would still like to track this in an issue.

google/cloud/billing_v1/services/cloud_catalog/client.py:19:1: F401 'typing.Iterable' imported but unused
google/cloud/billing_v1/services/cloud_catalog/client.py:19:1: F401 'typing.Iterator' imported but unused
google/cloud/billing_v1/services/cloud_catalog/client.py:23:1: F401 'google.api_core.exceptions' imported but unused
google/cloud/billing_v1/services/cloud_billing/client.py:19:1: F401 'typing.Iterable' imported but unused
google/cloud/billing_v1/services/cloud_billing/client.py:19:1: F401 'typing.Iterator' imported but unused
google/cloud/billing_v1/services/cloud_billing/client.py:23:1: F401 'google.api_core.exceptions' imported but unused
tests/unit/billing_v1/test_cloud_catalog.py:21:1: F401 'math' imported but unused
tests/unit/billing_v1/test_cloud_billing.py:21:1: F401 'math' imported but unused
@busunkim96 busunkim96 added the type: cleanup An internal cleanup or hygiene concern. label Feb 27, 2020
@software-dov
Copy link
Contributor

software-dov commented Feb 28, 2020

Mostly fixed by #329
Unused 'math' import is still present in generated tests.
Unused 'exceptions' import is still present in generated client.

@larkee
Copy link

larkee commented Sep 17, 2020

For Cloud Spanner, tests/unit/gapic/spanner_v1/test_spanner.py contains the following unused imports:

from google.cloud.spanner_v1.types import type
from google.cloud.spanner_v1.types import type as gs_type

The first import is causing test breakages as it clashes with the type() builtin.

@software-dov
Copy link
Contributor

Fixed by #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

3 participants