fix: update GOOGLE_API_USE_MTLS values #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go client uses lower case, so change the values to lower case.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1453 1453
Branches 300 300
=========================================
Hits 1453 1453 Continue to review full report at Codecov.
|
|
@software-dov Once this is merged, could you cut a release? I want to release a new version of the service directory with the fixes in #424 Thank you! 😁 |
software-dov
approved these changes
Jun 10, 2020
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go client uses lower case, so change the values to lower case.
https://github.com/googleapis/google-api-go-client/blob/master/transport/http/dial.go#L31-L35