Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for proto3 optional fields #519

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

software-dov
Copy link
Contributor

Fields marked as 'optional' in proto files are given an 'optional=True' parameter in their constructor.
Bumps required version of proto-plus in gapic surface to 1.1.0
Includes minor cleanups in template code that refers to oneofs.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2020
@software-dov software-dov changed the title feat: add support for proto3 optional fields feat: support for proto3 optional fields Jul 13, 2020
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #519 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #519   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1476      1507   +31     
  Branches       308       308           
=========================================
+ Hits          1476      1507   +31     
Impacted Files Coverage Δ
gapic/schema/api.py 100.00% <0.00%> (ø)
gapic/schema/imp.py 100.00% <0.00%> (ø)
gapic/utils/cache.py 100.00% <0.00%> (ø)
gapic/schema/metadata.py 100.00% <0.00%> (ø)
gapic/schema/wrappers.py 100.00% <0.00%> (ø)
gapic/generator/options.py 100.00% <0.00%> (ø)
gapic/samplegen/samplegen.py 100.00% <0.00%> (ø)
gapic/samplegen_utils/types.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e9bee...5622442. Read the comment docs.

@software-dov software-dov merged commit 1aa729c into googleapis:master Jul 13, 2020
@software-dov software-dov deleted the optional branch July 13, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants