Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespaces like 'v1alpha' and 'v1beta' are generated as 'v1' #539

Closed
busunkim96 opened this issue Jul 20, 2020 · 0 comments · Fixed by #540
Closed

Namespaces like 'v1alpha' and 'v1beta' are generated as 'v1' #539

busunkim96 opened this issue Jul 20, 2020 · 0 comments · Fixed by #540
Assignees
@busunkim96
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@busunkim96
Copy link
Contributor

See game servers and analytics admin.

The generator detects the version as v1 if there isn't a number after alpha/beta.

gapic-generator-python/gapic/schema/naming.py

Line 102 in 86fd1ac

version = r'\.(?P<version>v[0-9]+(p[0-9]+)?((alpha|beta)[0-9]+)?)'

v1alpha1 -> v1alpha1
v1alpha -> v1
@busunkim96 busunkim96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jul 20, 2020
@busunkim96 busunkim96 mentioned this issue Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make # after alpha/beta optional googleapis/gapic-generator-python
1 participant
@busunkim96