fix: retriable exceptions are deterministically ordered in GAPICs #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain code patterns in the generated surface are created by iteration over data collections. This iteration order should be deterministic in order to prevent spurious deltas in the generated surface.
software-dov
requested review from
tseaver,
crwilcox,
vchudnov-g,
busunkim96 and
arithmetic1728
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1525 1525
Branches 309 309
=========================================
Hits 1525 1525 Continue to review full report at Codecov.
|
busunkim96
approved these changes
Sep 24, 2020
tseaver
added a commit
to googleapis/python-firestore
that referenced
this pull request
Sep 24, 2020
Sorting issue, googleapis/gapic-generator-python#617, fixed by googleapis/gapic-generator-python#619 Co-authored-by: Tres Seaver <[email protected]>
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain code patterns in the generated surface are created by
iteration over data collections. This iteration order should be
deterministic in order to prevent spurious deltas in the generated surface.