Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove client recv msg limit #704

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Conversation

busunkim96
Copy link
Contributor

Closes #669

Replicates change made in monolithic generator to remove client side size limits.
googleapis/gapic-generator#2900 googleapis/gapic-generator#2905

@busunkim96 busunkim96 requested a review from a team as a code owner December 10, 2020 00:55
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2020
@busunkim96 busunkim96 changed the title Remove client recv msg limit fix: remove client recv msg limit Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #704 (fbd4d44) into master (f28b43d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #704   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1598      1598           
  Branches       324       324           
=========================================
  Hits          1598      1598           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28b43d...fbd4d44. Read the comment docs.

@@ -101,6 +101,10 @@ class {{ service.name }}RestTransport({{ service.name }}Transport):
self._host,
credentials=self._credentials,
scopes=self.AUTH_SCOPES,
options=[
Copy link
Contributor Author

@busunkim96 busunkim96 Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the options wherever a channel was created, but am not 100% sure if it makes sense here (in the rest transport). @yon-mg could you take a look?

@busunkim96 busunkim96 merged commit 80147ce into master Dec 10, 2020
@busunkim96 busunkim96 deleted the remove-client-recv-msg-limit branch December 10, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove client-side enforcement of send/recv message size limit
2 participants