-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mtls feature to rest transport #731
Conversation
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1619 1619
Branches 328 328
=========================================
Hits 1619 1619 Continue to review full report at Codecov.
|
Thanks for doing this! |
gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2
Outdated
Show resolved
Hide resolved
1d8dccf
to
644a085
Compare
644a085
to
c927e53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor naming nit.
Currently only grpc transport support mtls. This PR adds mtls support to http transport and fixes #383. The logic is the same. The only difference is we use different apis for different transports.
The following table shows the apis used for certificates.
The following code (extracted from the PR) demonstrates the api differences.
http (new code from this PR)
grpc (existing code)