Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showcase unit tests missing for rest transport #744

Closed
arithmetic1728 opened this issue Jan 21, 2021 · 3 comments
Closed

showcase unit tests missing for rest transport #744

arithmetic1728 opened this issue Jan 21, 2021 · 3 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. test coverage

Comments

@arithmetic1728
Copy link
Collaborator

It seems circleci currently only generates and runs the showcase unit tests for grpc transport. We need some unit tests for rest transport with showcase protos.

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 21, 2021
@yon-mg
Copy link
Contributor

yon-mg commented Jan 28, 2021

This is intended. Currently the only way to generate the rest transport is including "rest" in the "transport" option of the python_gapic_out flag (e.g. --python_gapic_out="transport=grpc+rest". This was decided instead of maintaining a separate long running branch here, #688 (comment).

Since all features have not yet been implemented, Showcase unit tests on rest transport are guaranteed to fail. This in combination with the above led to the choice of not including rest generation for CircleCI until rest transport features are complete.

@arithmetic1728
Copy link
Collaborator Author

@yon-mg I see. Thank you for the details! Let's mark it p3.

@arithmetic1728 arithmetic1728 added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Jan 28, 2021
@yoshi-automation yoshi-automation removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 28, 2021
@software-dov
Copy link
Contributor

Tests have been added for both echo and compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. test coverage
Projects
None yet
Development

No branches or pull requests

4 participants