-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consistently use _pb2 identifier #883
Conversation
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1694 +86
Branches 328 347 +19
=========================================
+ Hits 1608 1694 +86
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a quick test to verify the new behavior?
…python into fix-pb2-refs
Small change to fix bug noticed in googleapis/python-dialogflow#288.
The import was
from google.rpc import status_pb2
but code expectedgr_status