Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable self signed jwt for grpc #920

Merged
merged 3 commits into from
Jun 16, 2021
Merged

feat: enable self signed jwt for grpc #920

merged 3 commits into from
Jun 16, 2021

Conversation

arithmetic1728
Copy link
Collaborator

@arithmetic1728 arithmetic1728 commented Jun 14, 2021

For grpc transport, set always_use_jwt_access to True for service account credentials to enable self signed jwt feature. This feature is for GAPIC only, so we don't do this for http transport.

The feature relies on the changes in googleapis/google-auth-library-python#776, which introduces with_always_use_jwt_access method in service account credentials to set always_use_jwt_access.
However, since in the code we only call with_always_use_jwt_access method if this method exists, this PR is backward compatible.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #920 (5444184) into master (7c185e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #920   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         1608      1703   +95     
  Branches       328       347   +19     
=========================================
+ Hits          1608      1703   +95     
Impacted Files Coverage Δ
gapic/samplegen_utils/types.py 100.00% <ø> (ø)
gapic/samplegen_utils/utils.py 100.00% <ø> (ø)
gapic/utils/case.py 100.00% <ø> (ø)
gapic/utils/reserved_names.py 100.00% <ø> (ø)
gapic/generator/generator.py 100.00% <100.00%> (ø)
gapic/samplegen/samplegen.py 100.00% <100.00%> (ø)
gapic/schema/api.py 100.00% <100.00%> (ø)
gapic/schema/metadata.py 100.00% <100.00%> (ø)
gapic/schema/wrappers.py 100.00% <100.00%> (ø)
gapic/utils/__init__.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e39f41...5444184. Read the comment docs.

@arithmetic1728 arithmetic1728 changed the title feat: enable self signe jwt for grpc feat: enable self signed jwt for grpc Jun 15, 2021
@arithmetic1728 arithmetic1728 marked this pull request as ready for review June 15, 2021 03:49
@arithmetic1728 arithmetic1728 requested a review from a team as a code owner June 15, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants