Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api key support #969

Merged
merged 3 commits into from
Jan 19, 2022
Merged

feat: add api key support #969

merged 3 commits into from
Jan 19, 2022

Conversation

arithmetic1728
Copy link
Collaborator

@arithmetic1728 arithmetic1728 commented Aug 11, 2021

This PR adds API key support. Internal doc: go/gapic-api-key-support

If api_key is provided via client_options, use the api key. Note that GOOGLE_API_KEY is handled by google-auth so we don't need to do anything in microgenerator.

Related PRs:
googleapis/google-auth-library-python#826
googleapis/python-api-core#248

Tested with language api:
https://github.com/arithmetic1728/python-language/commit/da9b1215d1a46e5dc2ccc10bf9a6d1edd9cb8940

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2021
@arithmetic1728 arithmetic1728 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 8, 2021
@arithmetic1728 arithmetic1728 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 19, 2022
@arithmetic1728 arithmetic1728 marked this pull request as ready for review January 19, 2022 08:54
@arithmetic1728 arithmetic1728 requested review from a team as code owners January 19, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants