Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeouts are handled by rest clients, retries silently ignored #976

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

software-dov
Copy link
Contributor

Passes hand tests

@software-dov software-dov requested a review from a team as a code owner August 20, 2021 22:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2021
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to handle retries at a later date?

It looks like the two manually authored REST clients BigQuery and Storage have their own retry class that uses google-api-core's retry object. It might be nicer to create a REST equivalent of _GapicCallable for REGAPIC instead of interacting with AuthorizedSession directly.

@software-dov software-dov merged commit a62463c into googleapis:master Aug 20, 2021
@software-dov
Copy link
Contributor Author

I believe that's the plan, yes. In the meantime, it's better to allow the parameter we can support easily and gracefully drop the one that will require more effort than blowing up because we weren't expecting the parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants