Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(samples): add disclaimer #1211

Merged
merged 4 commits into from
Aug 18, 2022
Merged

fix(samples): add disclaimer #1211

merged 4 commits into from
Aug 18, 2022

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Aug 17, 2022 •
edited
Loading

Fixes b/240118972 internally

Labeling it as a feat so that it releases a new version of the generator, but will send the individual PRs out as docs

@sofisl sofisl requested a review from a team as a code owner August 17, 2022 22:04
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 17, 2022
@sofisl sofisl changed the title fix(samples): add disclaimer feat(samples): add disclaimer Aug 17, 2022
@alexander-fenster alexander-fenster changed the title feat(samples): add disclaimer fix(samples): add disclaimer Aug 18, 2022
@alexander-fenster
Copy link
Contributor

fix should be enough to trigger a release here.

@alexander-fenster alexander-fenster merged commit c0fd282 into main Aug 18, 2022
@alexander-fenster alexander-fenster deleted the addDisclaimer branch August 18, 2022 19:03
@release-please release-please bot mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sofisl @alexander-fenster