Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use ClientOptions gaxServerStreamingRetries value #1571

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

leahecole
Copy link
Contributor

Instead of setting gaxServerStreamingRetries to false, set it to the value in ClientOptions or default to false if not set

Tests in the gax-nodejs test-application should be passing in googleapis/gax-nodejs#1583

@leahecole
Copy link
Contributor Author

Ooo, there are clearly some other things I need to update - I have to run to a meeting but I will read the error logs to see what needs to be changed. If it's not obvious though, any hints of what I need to fix would be appreciated!

@alexander-fenster
Copy link
Contributor

When you update templates, you also need to update baselines; npm run baseline will do the trick! (takes a few minutes, give it some time)

@leahecole leahecole merged commit 86e68d2 into main Apr 10, 2024
27 checks passed
@leahecole leahecole deleted the retries-template branch April 10, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants