Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: have only one descriptors object #640

Open
alexander-fenster opened this issue Aug 10, 2020 · 0 comments
Open

refactor: have only one descriptors object #640

alexander-fenster opened this issue Aug 10, 2020 · 0 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@alexander-fenster
Copy link
Contributor

Right now, the generated code has a non-trivial descriptor object such as

class Client {
  ...
  descriptors: {
    page: { ... },
    stream: { ... },
    longrunning: { ... },
    batching: { ... },
  }
  ...
}

This is actually an overcomplicated object since a method can only be paging, or streaming, or longrunning, or support batching, but not two of those at the same time. We need to replace it with just one descriptors object (key: method name, value: any descriptor).

This will formally be a breaking change because someone could depend on a given descriptor present (we actually gave some advice about that long time ago), so this should wait till the next major version bump.

@alexander-fenster alexander-fenster added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Aug 10, 2020
@alexander-fenster alexander-fenster self-assigned this Aug 10, 2020
@alexander-fenster alexander-fenster removed their assignment Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant