Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpc with google.cloud.operation_polling_method to showcase protos #1508

Open
parthea opened this issue Apr 25, 2024 · 1 comment
Open
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@parthea
Copy link
Contributor

parthea commented Apr 25, 2024

Commit googleapis/googleapis@e495ff5 had a failed build related to a gap in testing in gapic-generator-python for the annotation google.cloud.operation_polling_method . See tests/fragments/test_compute_operation.proto which was added in googleapis/gapic-generator-python#2014 to fix the testing gap.

This issue is to track adding google.cloud.operation_polling_method to gapic-showcase and https://google.aip.dev/

@parthea parthea added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 25, 2024
@noahdietz noahdietz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 1, 2024
@noahdietz
Copy link
Collaborator

I am a little hesitant to put diregapic stuff in showcase b.c it isn't a diregapic API. When we start mixing things we may start crossing wires and breaking "normal" stuff.

In Go we have a "generation integration test" for Compute where we generate the Compute client and compile it to ensure it is valid. Similar in PHP, we use a generation integration test and run the unit tests.

Could you do something similar in Python?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants