Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for custom backoff #498

Merged
merged 9 commits into from
Mar 6, 2023
Merged

Conversation

camflan
Copy link
Contributor

@camflan camflan commented Aug 15, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #452 🦕

@camflan camflan requested a review from a team as a code owner August 15, 2022 18:28
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 15, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@google-cla
Copy link

google-cla bot commented Aug 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ddelgrosso1
Copy link
Contributor

Hi @camflan thank you for the PR. Can you update the commit message to follow conventional commits.

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 7, 2022
@camflan camflan changed the title Add support for custom backoff feat: Add support for custom backoff Jan 19, 2023
@camflan
Copy link
Contributor Author

camflan commented Jan 19, 2023

Hi @camflan thank you for the PR. Can you update the commit message to follow conventional commits.

done! sorry for the delay

@camflan
Copy link
Contributor Author

camflan commented Jan 23, 2023

@ddelgrosso1 I think this is ready to run CI workflows

@camflan
Copy link
Contributor Author

camflan commented Mar 6, 2023

@ddelgrosso1 Ready to go

@ddelgrosso1
Copy link
Contributor

ddelgrosso1 commented Mar 6, 2023

Thanks @camflan, apologies on the delay. Will get this merged today. Can you run npm run fix to fix the linter issues?

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 6, 2023
@camflan
Copy link
Contributor Author

camflan commented Mar 6, 2023

Thanks @camflan, apologies on the delay. Will get this merged today. Can you run npm run fix to fix the linter issues?

Awesome, thanks! Pushed fix for formatting just now

@ddelgrosso1
Copy link
Contributor

Thanks again for the contribution @camflan!

@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 6, 2023
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onRetryAttempt is not awaited / custom back off strategy
3 participants