Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: translate GaxiosError message to object regardless of return type (return data as default) #546

Merged
merged 7 commits into from
Jul 5, 2023
Merged

fix: translate GaxiosError message to object regardless of return type (return data as default) #546

merged 7 commits into from
Jul 5, 2023

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Jun 29, 2023

One further fix from #537, which was reverted: we return data as default, instead of data.text()

@sofisl sofisl requested a review from a team as a code owner June 29, 2023 20:11
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 29, 2023
@sofisl sofisl merged commit adfd570 into main Jul 5, 2023
12 checks passed
@sofisl sofisl deleted the translateErrorToString branch July 5, 2023 17:51
@release-please release-please bot mentioned this pull request Jul 5, 2023
Merged
This was referenced Sep 14, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sofisl @ddelgrosso1