Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): change HttpBody.Data from string to any for monitoring:v1 #2744

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Aug 21, 2024

fixes: #2304

@quartzmo quartzmo requested review from yoshi-approver and a team as code owners August 21, 2024 23:46
@quartzmo quartzmo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 21, 2024
@quartzmo
Copy link
Member Author

Adding do not merge pending discussion of this change in #2304.

@quartzmo
Copy link
Member Author

Manual local testing of entire repo regen:

➜  google-api-go-generator git:(monitoring-v1-fix) ./google-api-go-generator -cache=true -install -gendir=..
2024/08/21 17:39:49 Generating API abusiveexperiencereport:v1
2024/08/21 17:39:50 Generating API acceleratedmobilepageurl:v1
...
2024/08/21 17:42:46 Generating API youtubereporting:v1
➜  google-api-go-generator git:(monitoring-v1-fix) ✗ git status
On branch monitoring-v1-fix
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   ../monitoring/v1/monitoring-gen.go

@codyoss codyoss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 22, 2024
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Aug 22, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit eda6a59 into googleapis:main Aug 22, 2024
5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 22, 2024
@quartzmo quartzmo deleted the monitoring-v1-fix branch August 22, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants