Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(asset): enable library on Windows #11714

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 24, 2023

Now that we use Protobuf >= 23.1 for most builds we can enable google/cloud/asset.

Part of the work for #8145


This change is Reviewable

Now that we use Protobuf >= 23.1 for most builds we can enable
`google/cloud/asset`.
@product-auto-label product-auto-label bot added the api: cloudasset Issues related to the Cloud Asset Inventory API. label May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (6672f7f) 93.78% compared to head (30e2dc5) 93.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11714      +/-   ##
==========================================
- Coverage   93.78%   93.78%   -0.01%     
==========================================
  Files        1829     1829              
  Lines      164843   164843              
==========================================
- Hits       154596   154590       -6     
- Misses      10247    10253       +6     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review May 24, 2023 14:43
@coryan coryan requested a review from a team as a code owner May 24, 2023 14:43
@coryan coryan enabled auto-merge (squash) May 24, 2023 16:21
@coryan coryan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2023
@google-cloud-cpp-bot google-cloud-cpp-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2023
@coryan coryan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2023
@google-cloud-cpp-bot google-cloud-cpp-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2023
@coryan coryan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2023
@google-cloud-cpp-bot google-cloud-cpp-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2023
@coryan coryan merged commit 375faf7 into googleapis:main May 24, 2023
@coryan coryan deleted the cleanup-enable-asset-library-on-Windows branch May 24, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants