Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-docker build fails when gRPC installed via package manager #2260

Closed
ghost opened this issue Mar 19, 2019 · 4 comments
Closed

Non-docker build fails when gRPC installed via package manager #2260

ghost opened this issue Mar 19, 2019 · 4 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ghost
Copy link

ghost commented Mar 19, 2019

OS: Fedora 29. This is peculiar because it seems to cause the build to fail even though we are explicitly asking for an external project build.

How to reproduce:

  • git clone
  • Install grpc grpc-devel grpc-plugins protobuf protobuf-compiler protobuf-devel

Then:

mkdir .build && cd .build
cmake .. -DGOOGLE_CLOUD_CPP_DEPENDENCY_PROVIDER=external
make -j4

Output from grpc_project-build-err.log:

--grpc_out: src/proto/grpc/reflection/v1alpha/reflection.proto: cpp grpc proto compiler plugin does not work with generic services. To generate cpp grpc APIs, please set "cc_generic_service = false".
gmake[5]: *** [CMakeFiles/grpc++_reflection.dir/build.make:64: gens/src/proto/grpc/reflection/v1alpha/reflection.grpc.pb.cc] Error 1
gmake[4]: *** [CMakeFiles/Makefile2:533: CMakeFiles/grpc++_reflection.dir/all] Error 2
gmake[4]: *** Waiting for unfinished jobs....
--grpc_out: src/proto/grpc/channelz/channelz.proto: cpp grpc proto compiler plugin does not work with generic services. To generate cpp grpc APIs, please set "cc_generic_service = false".
--grpc_out: src/proto/grpc/status/status.proto: cpp grpc proto compiler plugin does not work with generic services. To generate cpp grpc APIs, please set "cc_generic_service = false".
gmake[5]: *** [CMakeFiles/grpc++_error_details.dir/build.make:64: gens/src/proto/grpc/status/status.grpc.pb.cc] Error 1
gmake[5]: *** [CMakeFiles/grpcpp_channelz.dir/build.make:64: gens/src/proto/grpc/channelz/channelz.grpc.pb.cc] Error 1
gmake[4]: *** [CMakeFiles/Makefile2:797: CMakeFiles/grpc++_error_details.dir/all] Error 2
gmake[4]: *** [CMakeFiles/Makefile2:185: CMakeFiles/grpcpp_channelz.dir/all] Error 2
gmake[3]: *** [Makefile:130: all] Error 2
@coryan coryan added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 20, 2019
@coryan
Copy link
Contributor

coryan commented Mar 20, 2019

I wonder if the gRPC CMakeLists.txt gets confused, we ask it to build with "package" as a source for Protobuf, because protobuf is installed in the .build/external/ directory, but maybe it is picking up some files from the system package and some from .build/external/?

@ghost
Copy link
Author

ghost commented Mar 21, 2019

This looks resolved now.

@ghost ghost closed this as completed Mar 21, 2019
@ghost
Copy link
Author

ghost commented Mar 21, 2019

Spoke too soon. Probably should let the build finish completely before I comment. An improvement (?) is that it now only complains about one proto file instead of three:

--grpc_out: src/proto/grpc/channelz/channelz.proto: cpp grpc proto compiler plugin does not work with generic services. To generate cpp grpc APIs, please set "cc_generic_service = false".
gmake[5]: *** [CMakeFiles/grpcpp_channelz.dir/build.make:64: gens/src/proto/grpc/channelz/channelz.grpc.pb.cc] Error 1
gmake[4]: *** [CMakeFiles/Makefile2:185: CMakeFiles/grpcpp_channelz.dir/all] Error 2

@ghost ghost reopened this Mar 21, 2019
@ghost
Copy link
Author

ghost commented Jul 17, 2019

Closing this since it will be superseded by #2802

@ghost ghost closed this as completed Jul 17, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant