Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PrintTo() in the nlohmann namespace #4748

Closed
coryan opened this issue Jul 31, 2020 · 0 comments · Fixed by #4773
Closed

Remove PrintTo() in the nlohmann namespace #4748

coryan opened this issue Jul 31, 2020 · 0 comments · Fixed by #4773
Assignees
@coryan
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@coryan
Copy link
Contributor

coryan commented Jul 31, 2020

This is intended as a follow up to the fixes for #2874. Probably should be tackled after after #4747 (or a similar PR) is merged.

We currently have an overload to PrintTo() in the ::nlohmann namespace to workaround a bug in googletest when printing recursive types. This seems to have been fixed circa 2017 (see google/googletest#1186), so we can remove the workaround.
@coryan coryan added the type: cleanup An internal cleanup or hygiene concern. label Jul 31, 2020
@coryan coryan self-assigned this Aug 4, 2020
@coryan coryan mentioned this issue Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup(storage): remove nlohmann::PrintTo() coryan/google-cloud-cpp
1 participant
@coryan