Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove unneeded build/Dockerfiles and cleanup build.sh #2926

Merged
merged 1 commit into from Jul 31, 2019
Merged

cleanup: Remove unneeded build/Dockerfiles and cleanup build.sh #2926

merged 1 commit into from Jul 31, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 31, 2019

Context:
#2802 (comment)
for rationale.


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2019
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I need to merge some changes internally to disable the centos-7 build first, and then I can run the Kokoro builds.

@coryan coryan added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #2926 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2926     +/-   ##
=========================================
- Coverage   90.75%   90.66%   -0.1%     
=========================================
  Files         297      297             
  Lines       19943    20021     +78     
=========================================
+ Hits        18100    18152     +52     
- Misses       1843     1869     +26
Impacted Files Coverage Δ
google/cloud/storage/oauth2/credentials.h 33.33% <0%> (-33.34%) ⬇️
google/cloud/storage/internal/complex_option.h 66.66% <0%> (-16.67%) ⬇️
google/cloud/storage/well_known_parameters.h 68.88% <0%> (-15.56%) ⬇️
google/cloud/storage/object_stream.h 98.14% <0%> (-1.86%) ⬇️
google/cloud/storage/internal/curl_client.cc 94.7% <0%> (-0.34%) ⬇️
google/cloud/storage/internal/object_streambuf.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/mutations.h 100% <0%> (ø) ⬆️
google/cloud/storage/object_metadata.h 100% <0%> (ø) ⬆️
google/cloud/internal/retry_policy.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/examples/data_snippets.cc 85.16% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b13d0a...484e632. Read the comment docs.

@coryan coryan merged commit 0ae7191 into googleapis:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants