Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove gcc 9 build #5437

Merged
merged 1 commit into from Nov 7, 2020
Merged

ci: remove gcc 9 build #5437

merged 1 commit into from Nov 7, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 6, 2020

Fixes: #4094


This change is Reviewable

@ghost ghost self-requested a review as a code owner November 6, 2020 23:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2020
@coryan coryan added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 7, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 7, 2020
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #5437 (2a41b66) into master (09f4f8d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5437      +/-   ##
==========================================
- Coverage   95.53%   95.53%   -0.01%     
==========================================
  Files        1055     1055              
  Lines       97863    97863              
==========================================
- Hits        93497    93495       -2     
- Misses       4366     4368       +2     
Impacted Files Coverage Δ
...bigtable/examples/bigtable_hello_instance_admin.cc 82.22% <0.00%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f4f8d...2a41b66. Read the comment docs.

@coryan coryan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2020
@coryan coryan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2020
@coryan coryan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2020
@coryan
Copy link
Contributor

coryan commented Nov 7, 2020

Do you mind rebasing (or recreating) this PR? I think Kokoro is just stuck with the old gcc-9 build results. New PRs are not starting the gcc-9 build. I just want to make sure my hypothesis is right.

@coryan coryan added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 7, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 7, 2020
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coryan coryan merged commit c44f871 into googleapis:master Nov 7, 2020
@ghost ghost deleted the cleanup-remove-gcc-9 branch November 7, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a build for GCC-10
4 participants