logging: instance_name label is not valid for GCE Instance Resource #4272
Labels
api: logging
Issues related to the Cloud Logging API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
google-cloud-go/logging/resource.go
Line 205 in 0232e6f
This code automatically detects and adds an
instance_name
label to the common resource object. However, theinstance_name
label never appears on any logs on the service side. I believe this is because the GCE instance resource only accepts a pre-validated set of labels which are the project, zone and instance ID. The code here should not add or send the instance_name label, and probably the service should reject resources with invalid labels to aid in discovery.The text was updated successfully, but these errors were encountered: