Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The header-check is failing in 2024 #10183

Closed
suztomo opened this issue Jan 2, 2024 · 3 comments
Closed

The header-check is failing in 2024 #10183

suztomo opened this issue Jan 2, 2024 · 3 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Jan 2, 2024

https://github.com/googleapis/google-cloud-java/pull/10133/checks?check_run_id=20098045951

Screenshot 2024-01-02 at 11 33 15 AM

and #10120

Screenshot 2024-01-02 at 10 53 30 AM
@suztomo
Copy link
Member Author

suztomo commented Jan 2, 2024 •
edited
Loading

The regenerate option didn't solve the problem, probably because the base CL or googleapis-gen was created in 2023. Maybe we'll disable this temporarily until all code generation starts to produce "2024" in the header.

@suztomo
Copy link
Member Author

suztomo commented Jan 2, 2024 •
edited
Loading

Marked the header-check as not required temporarily. I keep this issue open until I mark it as required when code generation starts to generate "2024" in header.

@mpeddada1 mpeddada1 mentioned this issue Jan 4, 2024
Merged
@JoeWang1127 JoeWang1127 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 4, 2024
@alicejli
Copy link
Contributor

@JoeWang1127 your PR fixed this right? Should this be closed?

@suztomo suztomo closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@suztomo @alicejli @JoeWang1127