Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document purpose of test-jar and testlib dependencies #3715

Closed
elharo opened this issue Sep 21, 2018 · 2 comments
Closed

Document purpose of test-jar and testlib dependencies #3715

elharo opened this issue Sep 21, 2018 · 2 comments
Assignees
@chingor13
Labels
status: in progress There is an open PR type: docs Improvement to the documentation for an API.

Comments

@elharo
Copy link
Contributor

elharo commented Sep 21, 2018

These aren't standard in Maven and aren't obvious from the code, at least to me.
@elharo elharo added documentation type: docs Improvement to the documentation for an API. labels Sep 21, 2018
@sduskis sduskis added type: docs Improvement to the documentation for an API. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: docs Improvement to the documentation for an API. labels Oct 9, 2018
@chingor13 chingor13 removed the testing label Oct 9, 2018
@chingor13 chingor13 self-assigned this Dec 3, 2018
@chingor13
Copy link
Contributor

The test-jar dependencies pull in the jar that contains the tests for the specified dependency. It's used because there may be reused tests or base test classes that are inherited for package tests.

I'll look for a place to document this.

@chingor13
Copy link
Contributor

The google-cloud-core test-jar is unnecessary for many clients, so I'm removing it from the dependencies.

@chingor13 chingor13 mentioned this issue Dec 3, 2018
Merged
@chingor13 chingor13 added status: in progress There is an open PR and removed documentation labels Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
status: in progress There is an open PR type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chingor13 @sduskis @elharo