Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable buffering to logging #1981

Closed
ofrobots opened this issue Feb 10, 2017 · 3 comments
Closed

Add configurable buffering to logging #1981

ofrobots opened this issue Feb 10, 2017 · 3 comments
Assignees
@stephenplusplus
Labels
api: logging Issues related to the Cloud Logging API.

Comments

@ofrobots
Copy link
Contributor

It would be nice to have optional buffering in the the logging client library so that all the higher level layers (e.g. logging-winston and logging-bunyan) and users don't have to build this independently.

Ref: #1977 (comment)

@stephenplusplus Thoughts?
/cc @cristiancavalli
@stephenplusplus
Copy link
Contributor

Since we use gRPC, which keeps an open channel, is batching still beneficial?

@stephenplusplus stephenplusplus added api: logging Issues related to the Cloud Logging API. perf labels Feb 10, 2017
@ofrobots
Copy link
Contributor Author

My understanding, as per the quota policy for Stackdriver Logging, the number of write calls are counted. Whether each of the calls go over the same channel wouldn't affect this, I expect.

@zbjornson has practical experience with the quota.

@stephenplusplus
Copy link
Contributor

This convo started to sound familiar. Let me re-open #1296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: logging Issues related to the Cloud Logging API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ofrobots @stephenplusplus