Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run test fails at HEAD #5725

Open
hegemonic opened this issue Sep 30, 2024 · 2 comments
Open

npm run test fails at HEAD #5725

hegemonic opened this issue Sep 30, 2024 · 2 comments
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@hegemonic
Copy link
Contributor

I cloned this repo, then ran the following commands in its root directory:

npm i
npm run test

The command returns an error, because semistandard reports errors in multiple files.

@sofisl sofisl added the type: process A process-related concern. May include testing, release, or the like. label Oct 1, 2024
@sofisl
Copy link
Contributor

sofisl commented Oct 1, 2024

There are no tests at the head of this repo. I'll fix the command but to run tests you need to go into each directory in packages.

@hegemonic
Copy link
Contributor Author

Yes, understood. But in #5724, I was making a change that affected the entire repo; I saw that there was a test target in the root package.json file, so I thought it was a good idea to run npm run test before sending a pull request.

If you don't want or need contributors to run npm run test in the repo root, please consider updating that target so it just prints a message telling users to run the command in the appropriate package directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

2 participants