Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP Transport for google-cloud-monitoring #11098

Open
courteouselk opened this issue Jan 6, 2021 · 2 comments
Open

Add support for HTTP Transport for google-cloud-monitoring #11098

courteouselk opened this issue Jan 6, 2021 · 2 comments
Labels
api: monitoring Issues related to the Cloud Monitoring API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@courteouselk
Copy link

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.

We are experiencing a problem with using python's multiprocessing (fork) together with google-cloud-monitoring library. This library uses gRPC that has problems with forking of the process. We had been observing things like hanging, deadlocks, memory corruption due to that. Eventually, we had to disable gRPC via GOOGLE_CLOUD_DISABLE_GRPC environment variable which did the thing for the logging library, but did not for the monitoring.

Describe the solution you'd like

Therefore, we would like to file a feature request that would enable alternative transports (e.g. HTTP) for the monitoring library.

@product-auto-label product-auto-label bot added the api: monitoring Issues related to the Cloud Monitoring API. label Jan 6, 2021
@busunkim96
Copy link
Contributor

Hi @courteouselk,

There is a HTTP transport that is in progress for the generated Python clients. We expect it to roll out to the libraries sometime this year. You can see googleapis/gapic-generator-python#267 for status.

Just in case, here is the note in our docs about multiprocessing:

Because this client uses grpcio library, it is safe to share instances across threads. In multiprocessing scenarios, the best practice is to create client instances after the invocation of os.fork() by multiprocessing.Pool or multiprocessing.Process.

@busunkim96 busunkim96 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 6, 2021
@busunkim96 busunkim96 changed the title Add support for GOOGLE_CLOUD_DISABLE_GRPC Add support for HTTP Transport Jan 6, 2021
@parthea
Copy link
Contributor

parthea commented Apr 18, 2023

This feature request is still outstanding. It should be completed this year.

I'm going to transfer this issue to the google-cloud-python repository as we are preparing to move the code for google-cloud-monitoring to that repository in the next 1-2 weeks.

@parthea parthea transferred this issue from googleapis/python-monitoring Apr 18, 2023
@parthea parthea changed the title Add support for HTTP Transport Add support for HTTP Transport for google-cloud-monitoring Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: monitoring Issues related to the Cloud Monitoring API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants